tests/unit/test_tool_annotations.py (1)

32-46: Consider parametrizing idempotent in the helper.

_assert_mutating_tool hard-codes idempotentHint is False, which couples the helper to the current set of callsites. If any mutating tool is later marked idempotent=True (e.g., updates — see comment on transactions.py), this helper will need a kwarg. A small forward-looking change keeps things symmetric with destructive:

♻️ Proposed change

 def _assert_mutating_tool(
     tool: Tool,
     title: str,
     *,
     destructive: bool = False,
+    idempotent: bool = False,
 ) -> None:
     """Assert standard annotations for mutating tools."""
     annotations = tool.annotations

     assert annotations is not None
     assert annotations.title == title
     assert annotations.readOnlyHint is False
     assert annotations.destructiveHint is destructive
-    assert annotations.idempotentHint is False
+    assert annotations.idempotentHint is idempotent
     assert annotations.openWorldHint is False

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/unit/test_tool_annotations.py` around lines 32 - 46, The helper
_assert_mutating_tool currently hard-codes annotations.idempotentHint as False;
add an idempotent: bool = False parameter to _assert_mutating_tool, update its
docstring to mention idempotency, and replace the hard-coded assertion with
assert annotations.idempotentHint is idempotent so callers can opt-in when a
mutating tool is idempotent.

src/lampyrid/tools/transactions.py (1)

142-163: Consider marking updates as idempotent.

Per the MCP idempotentHint semantics ("calling repeatedly with the same arguments has no additional effect on the environment"), update_transaction and bulk_update_transactions are idempotent — applying the same payload twice produces the same end state. The mutating_annotations helper already exposes this flag but no callsite sets it. This will require updating the test expectations (_assert_mutating_tool currently hard-asserts idempotentHint is False for all mutating tools).

♻️ Proposed change

     `@transactions_mcp.tool`(
         tags={'transactions', 'manage'},
-        annotations=mutating_annotations('Update Transaction'),
+        annotations=mutating_annotations('Update Transaction', idempotent=True),
     )
     async def update_transaction(req: UpdateTransactionRequest) -> Transaction:
@@
     `@transactions_mcp.tool`(
         tags={'transactions', 'manage', 'bulk'},
-        annotations=mutating_annotations('Bulk Update Transactions'),
+        annotations=mutating_annotations('Bulk Update Transactions', idempotent=True),
     )
     async def bulk_update_transactions(req: BulkUpdateTransactionsRequest) -> BulkUpdateResult:

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/lampyrid/tools/transactions.py` around lines 142 - 163, The mutating
tools update_transaction and bulk_update_transactions should be marked
idempotent via the existing mutating_annotations helper: change the calls to
mutating_annotations('Update Transaction') and mutating_annotations('Bulk Update
Transactions') to pass the idempotent flag (e.g., mutating_annotations('Update
Transaction', idempotent=True) and mutating_annotations('Bulk Update
Transactions', idempotent=True)); also update the test helper
_assert_mutating_tool to stop hard-asserting idempotentHint is False (make it
accept a configurable expectation or assert True for these tools) so the tests
reflect the idempotent semantics.